det101 commented on PR #18585: URL: https://github.com/apache/dolphinscheduler/pull/18585#issuecomment-5693619323
@SbloodyS Thanks for catching these. 1. **`commandParam` leak** — addressed in `ea46d67873`. `mask(WorkflowInstance)` now parses `ICommandParam`, masks `commandParams` on the response copy, and leaves the persisted/in-process value unchanged. Added `SensitivePropertyUtilsTest.maskWorkflowInstanceMasksCommandParam`. 2. **PR description** — updated to match the current design: controller typed `mask(...)` (no `ResponseBodyAdvice`), create/update placeholder rules, and API `restoreStartParams` (Master does not interpret `******`). Please take another look when you have a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
