det101 commented on code in PR #18585:
URL:
https://github.com/apache/dolphinscheduler/pull/18585#discussion_r4021715985
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/WorkflowDefinitionServiceImpl.java:
##########
@@ -262,6 +264,11 @@ public WorkflowDefinition createWorkflowDefinition(User
loginUser,
List<TaskDefinitionLog> taskDefinitionLogs =
generateTaskDefinitionList(taskDefinitionJson);
List<WorkflowTaskRelationLog> taskRelationList =
generateTaskRelationList(taskRelationJson, taskDefinitionLogs);
+
SensitivePropertyUtils.requireNoPlaceholder(GlobalParameterUtils.deserializeGlobalParameter(globalParams));
+ for (TaskDefinitionLog taskDefinitionLog :
CollectionUtils.emptyIfNull(taskDefinitionLogs)) {
+ taskDefinitionLog.setTaskParams(
+
SensitivePropertyUtils.mergeLocalParams(taskDefinitionLog.getTaskParams(),
null));
Review Comment:
Thanks. This line only rejects ****** in task localParams on create
(mergeLocalParams(..., null)). It doesn’t change the stored values. I reused
that helper instead of adding a validate-only method. I’ll leave it as-is
unless you prefer to split it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
