zhuangchong commented on pull request #3243: URL: https://github.com/apache/incubator-dolphinscheduler/pull/3243#issuecomment-662181832
1. SqlParameters = = null, because the key parameters have been checked in the UI, where SqlParameters cannot be null 2. For the exception of connection closing, the log should be added. In my opinion, if an exception occurs, the connection = = null --- 1. sqlParameters ==null , 因为在UI里面已经对关键参数进行校验，此处sqlParameters不可能为null 2.针对connection关闭发生异常增加日志，我认为更应该如果发生异常将connection==null ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
