gabrywu commented on a change in pull request #3243:
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/3243#discussion_r459867508
##########
File path:
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java
##########
@@ -87,7 +87,7 @@ public SqlTask(TaskExecutionContext taskExecutionContext,
Logger logger) {
logger.info("sql task params {}",
taskExecutionContext.getTaskParams());
this.sqlParameters =
JSONUtils.parseObject(taskExecutionContext.getTaskParams(),
SqlParameters.class);
- if (!sqlParameters.checkParameters()) {
+ if (sqlParameters == null || (!sqlParameters.checkParameters())) {
Review comment:
why this condition removed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
