yangyichao-mango edited a comment on pull request #3243:
URL: 
https://github.com/apache/incubator-dolphinscheduler/pull/3243#issuecomment-662265749


   > ## If SqlParameters is judged to be null, are all abstractparameters 
required? If so, they need to be abstracted
   > 如果SqlParameters判断为空,那么是不是所有的 AbstractParameters的都需要,如果是,就需要抽象出来
   
   I agree with you, if you are interested in this, I think it is better to 
create an issue and describe all the situation, this pr is just for spell error 
and some log info. Thx a lot~


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to