SbloodyS commented on code in PR #9840:
URL: https://github.com/apache/dolphinscheduler/pull/9840#discussion_r861417848
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-flink/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkConstants.java:
##########
@@ -24,19 +24,48 @@ private FlinkConstants() {
}
/**
- * flink
+ * flink command
+ * usage: flink run [OPTIONS] <jar-file> <arguments>
+ */
+ public static final String FLINK_COMMAND = "flink";
+ public static final String FLINK_RUN = "run";
+
+ /**
+ * flink sql command
+ * usage: sql-client.sh -i <initialization file>, -j <JAR file>, -f
<script file>...
+ */
+ public static final String FLINK_SQL_COMMAND = "sql-client.sh";
Review Comment:
Please note that flink ```sql-client.sh -f``` is only supported after
version 1.13. And ```sql-client.sh``` at version 1.13 and 1.14. and 1.15 have
some completely incompatible contents in these three versions. If we add flink
sql support. We should put it in the frontend page and document to let users
distinguish it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
