Dannila commented on code in PR #9840:
URL: https://github.com/apache/dolphinscheduler/pull/9840#discussion_r861422745
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-flink/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkConstants.java:
##########
@@ -24,19 +24,48 @@ private FlinkConstants() {
}
/**
- * flink
+ * flink command
+ * usage: flink run [OPTIONS] <jar-file> <arguments>
+ */
+ public static final String FLINK_COMMAND = "flink";
+ public static final String FLINK_RUN = "run";
+
+ /**
+ * flink sql command
+ * usage: sql-client.sh -i <initialization file>, -j <JAR file>, -f
<script file>...
+ */
+ public static final String FLINK_SQL_COMMAND = "sql-client.sh";
Review Comment:
> Please note that flink `sql-client.sh -f` is only supported after version
1.13. And `sql-client.sh` at version 1.13 and 1.14. and 1.15 have some
completely incompatible contents in these three versions. If we add flink sql
support. We should put it in the frontend page and document to let users
distinguish it.
Flink sql requires sql-client.sh -f <script file> to facilitate users to
edit sql scripts. I set it on the front end. When the user selects the flink
task and selects sql, the version of flink is >= 1.13 and cannot be changed.
flink1.15 also supports sql-client.sh -f
https://nightlies.apache.org/flink/flink-docs-release-1.15/zh/docs/dev/table/sqlclient/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
