Radeity commented on PR #13930:
URL:
https://github.com/apache/dolphinscheduler/pull/13930#issuecomment-1512507214
> If the command executed in the pod is perl -Mbignum=bpi -wle print
bpi(2000), that would be a problem.
>
> For example, the user command is echo '$SHELL', which the expected output
is $SHELL
>
> But if the quotes are removed and the command becomes echo $SHELL (or
"echo" "$SHELL"), the output would be sth like /bin/bash, which is not the
expected result
You're right, that's a corner case, however, we can not use `/bin/bash -c
"echo '$SHELL'"` in this case, it will still output the value of $SHELL. In
addition, if we keep the single quotes, i've tried that commands will be:
```
spec:
containers:
- command:
- echo
- '''$PATH'''
```
The output will be `'$PATH'` with unexpected single quotes. So i think what
we can do is to remove quotes for most cases, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
