rickchengx commented on PR #13930:
URL:
https://github.com/apache/dolphinscheduler/pull/13930#issuecomment-1517276877
> > Good work 👍
> > Could u please give some test results to verify that `command` and
`args` in `yaml` are consistent with the user input when 3 kinds of quotes are
included
>
> Hi, @rickchengx , i use yaml lib to parse that yaml-style array, that must
be consistent. We just parse commands and args in the same way with yaml lib of
kubernetes. I think they must follow the same logic.
>
> ```java
> if (!StringUtils.isEmpty(commandString)) {
> commands = yaml.load(commandString.trim());
> }
> ```
>
> May i ask how can i give test results? Just simply verify that the two
yaml library can parse yaml-style string in same way?
Yes, you could verify the cases with 3 kinds of quotes. Not sure if there is
unexpected output with quotes.
E.g., `"'$SHELL'"` would become `'''$SHELL'''` in the previous discussion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
