rickchengx commented on PR #13930: URL: https://github.com/apache/dolphinscheduler/pull/13930#issuecomment-1514105300
> > > > > > > > > I don't think it's a corner case, quotes have a special effect in bash, we shouldn't change the user command. > > ``` > > spec: > > containers: > > - command: > > - echo > > - '''$SHELL''' > > ``` > > > > > > > > > > > > > > > > > > > > > > > > > > * It's weird in `'''$SHELL'''` since the input is `'$SHELL'`, it seems to be related to k8s > > * Is there a better solution for this? My suggestion is to not introduce new problems until we find a better way to solve the problem of quotes > > You're right, we can not leave this potential bug. How about let user themselves define entire command like what they define in yaml?  We can directly acquire command array by splitting command string by comma. Also, we can add some doc to explain its usage. I agree If this way the user's quotes won't lose their effect. I suggest that all 3 kinds of quotes need to be tested to see if there is expected output E.g. ``` echo '$SHELL' echo `ls -la` echo "ab cd ef" | grep "ab cd" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
