rickchengx commented on PR #13930:
URL:
https://github.com/apache/dolphinscheduler/pull/13930#issuecomment-1517406228
> > E.g., `"'$SHELL'"` would become `'''$SHELL'''` in the previous discussion
>
> Yes, of course it will...
>
> If user defines commands in yaml (which is a more common way than json)
before: `command: ["echo", "'$SHELL'"]` when they don't use DS. Now, they use
DS, directly copy commands string, we can make sure that submit job with same
commands like before, cuz we don't change any parse logic. So i think there's
no need to tell user how to write command array, either, users should check k8s
doc or yaml doc.
>
> > And also it would be greater if these 3 examples (or other) could be
given in the doc to let user know how to write the command arrays with the
quotes
>
> Like we discuss before, quotes may have different usages in user commands,
there's no generous example.
You mean that if the user input is `command: ["echo", "'$SHELL'"]`
the yaml will get
```
- command:
- echo
- '''$SHELL'''
```
which means the command string in yaml is not consistent with the user input
?
what about `command: ['echo', ''$SHELL'']` ?
Since the doc of k8s use single quotes
https://kubernetes.io/zh-cn/docs/concepts/workloads/pods/
I think test results need to be given to decide which way should we use to
write the command array
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
