imay commented on a change in pull request #2332: Check the return status of
`_flush_memtable_async()`
URL: https://github.com/apache/incubator-doris/pull/2332#discussion_r351826565
##########
File path: be/src/runtime/tablets_channel.cpp
##########
@@ -25,11 +25,9 @@
namespace doris {
-TabletsChannel::TabletsChannel(
- const TabletsChannelKey& key,
- MemTracker* mem_tracker):
- _key(key), _closed_senders(64) {
- _mem_tracker.reset(new MemTracker(-1, "tablets channel", mem_tracker));
+TabletsChannel::TabletsChannel(const TabletsChannelKey& key, MemTracker*
parent) :
Review comment:
I don't think parent is a good name, parent looks like parent of
tabletsChannel not only a MemTracker.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
