imay commented on a change in pull request #2332: Check the return status of
`_flush_memtable_async()`
URL: https://github.com/apache/incubator-doris/pull/2332#discussion_r351825600
##########
File path: be/src/runtime/tablets_channel.h
##########
@@ -36,25 +36,17 @@ struct TabletsChannelKey {
UniqueId id;
int64_t index_id;
- TabletsChannelKey(const PUniqueId& pid, int64_t index_id_)
- : id(pid), index_id(index_id_) { }
+ TabletsChannelKey(const PUniqueId& pid, int64_t idx_id) : id(pid),
index_id(idx_id) { }
- ~TabletsChannelKey() noexcept { }
+ ~TabletsChannelKey() { }
- bool operator==(const TabletsChannelKey& rhs) const noexcept {
+ bool operator==(const TabletsChannelKey& rhs) const {
Review comment:
Is there any reason to drop noexcept?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
