imay commented on a change in pull request #2332: Check the return status of
`_flush_memtable_async()`
URL: https://github.com/apache/incubator-doris/pull/2332#discussion_r351826140
##########
File path: be/src/runtime/tablets_channel.cpp
##########
@@ -104,20 +102,20 @@ Status TabletsChannel::add_batch(const
PTabletWriterAddBatchRequest& params) {
return Status::OK();
}
-Status TabletsChannel::close(int sender_id, bool* finished,
+Status TabletsChannel::close(int sender_idx, bool* finished,
Review comment:
why change sender_id to sender_idx? I think if there is no strong reason,
better to keep the original name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
