kangpinghuang commented on a change in pull request #2212: Add rowset convert
URL: https://github.com/apache/incubator-doris/pull/2212#discussion_r351969159
##########
File path: be/src/olap/snapshot_manager.cpp
##########
@@ -546,4 +576,34 @@ OLAPStatus SnapshotManager::_create_snapshot_files(
return res;
}
+OLAPStatus SnapshotManager::_convert_beta_rowsets_to_alpha(const
TabletMetaSharedPtr& new_tablet_meta,
+ const vector<RowsetMetaSharedPtr>& beta_rowsets, const
std::string& dst_path,
+ std::vector<RowsetMetaSharedPtr>* new_rowsets, bool* modified)
{
+ OLAPStatus res = OLAP_SUCCESS;
+ RowsetConverter rowset_converter(new_tablet_meta);
+ for (auto& rowset_meta : beta_rowsets) {
+ if (rowset_meta->rowset_type() == BETA_ROWSET) {
+ *modified = true;
+ RowsetMetaPB rowset_meta_pb;
+ LOG(INFO) << "convert beta rowset:" << rowset_meta->rowset_id() <<
" to alpha";
Review comment:
I add this log to record which rowset is converted. I add the converted
rowset id to the log.
Tablet id can be determined in the context.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
