kangpinghuang commented on a change in pull request #2212: Add rowset convert
URL: https://github.com/apache/incubator-doris/pull/2212#discussion_r351976797
##########
File path: be/src/agent/agent_server.cpp
##########
@@ -410,11 +410,12 @@ void AgentServer::make_snapshot(TAgentResult&
return_value,
vector<string> error_msgs;
TStatusCode::type status_code = TStatusCode::OK;
int32_t return_snapshot_version = PREFERRED_SNAPSHOT_VERSION;
- // if the request's snapshot version is less than current be's snapshot
version
+ // if the request's snapshot version is less than snapshot version 3
// it means the request be is under old version. just set the request
version to 1
// current be will generate snapshot files like
tabletid_schemahash_startversion_endversion
// format. Every be is able to parse this format snapshot files.
- if (snapshot_request.preferred_snapshot_version <
PREFERRED_SNAPSHOT_VERSION) {
+ // NOTE: ALPHA_ROWSET_VERSION is 3, which is for alpha rowset format.
+ if (snapshot_request.preferred_snapshot_version < ALPHA_ROWSET_VERSION) {
Review comment:
no, it is <
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
