kangpinghuang commented on a change in pull request #2212: Add rowset convert
URL: https://github.com/apache/incubator-doris/pull/2212#discussion_r352329856
##########
File path: be/src/agent/agent_server.cpp
##########
@@ -409,13 +409,12 @@ void AgentServer::make_snapshot(TAgentResult&
return_value,
TStatus status;
vector<string> error_msgs;
TStatusCode::type status_code = TStatusCode::OK;
- int32_t return_snapshot_version = PREFERRED_SNAPSHOT_VERSION;
- // if the request's snapshot version is less than current be's snapshot
version
- // it means the request be is under old version. just set the request
version to 1
- // current be will generate snapshot files like
tabletid_schemahash_startversion_endversion
- // format. Every be is able to parse this format snapshot files.
- if (snapshot_request.preferred_snapshot_version <
PREFERRED_SNAPSHOT_VERSION) {
- return_snapshot_version = 1;
+ int32_t return_snapshot_version = BETA_ROWSET_VERSION;
+ // If the request's preferred snapshot version is ALPHA,
+ // Then we will convert the BETA to ALPHA
+ // So, set the return_snapshot_version to ALPHA
+ if (snapshot_request.preferred_snapshot_version == ALPHA_ROWSET_VERSION) {
+ return_snapshot_version = ALPHA_ROWSET_VERSION;
}
Review comment:
Error is returned by set make_snapshot_status to be not OLAP_SUCCESS. It has
been done in SnapshotManager
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
