yiguolei commented on code in PR #22442:
URL: https://github.com/apache/doris/pull/22442#discussion_r1306781381
##########
be/src/olap/data_dir.cpp:
##########
@@ -379,6 +381,17 @@ Status DataDir::load() {
if (rowset_meta->is_local()) {
rowset_meta->set_fs(local_fs);
}
+ if (rowset_meta->has_delete_predicate()) {
+ auto* delete_pred = rowset_meta->mutable_delete_pred_pb();
+ DeleteHandler::convert_to_sub_pred_v2(delete_pred,
rowset_meta->tablet_schema());
+ LOG(INFO) << fmt::format(
+ "convert rowset with old delete pred: rowset_id={},
tablet_id={}",
+ rowset_id.to_string(), tablet_uid.to_string());
+ std::string result;
+ rowset_meta->serialize(&result);
+ std::string key = ROWSET_PREFIX + tablet_uid.to_string() + "_" +
rowset_id.to_string();
+ _meta->put(META_COLUMN_FAMILY_INDEX, key, result);
Review Comment:
Add a check here: check the field for delete predicate v1 is not changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
