zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1863197534
##########
be/src/vec/data_types/data_type_quantilestate.h:
##########
@@ -94,9 +94,7 @@ class DataTypeQuantileState : public IDataType {
Field get_default() const override { return QuantileState(); }
[[noreturn]] Field get_field(const TExprNode& node) const override {
- throw doris::Exception(ErrorCode::NOT_IMPLEMENTED_ERROR,
- "Unimplemented get_field for quantile state");
- __builtin_unreachable();
+ throw Exception(Status::FatalError("Unimplemented get_field for
quantile state"));
Review Comment:
do not change this
##########
be/src/vec/data_types/data_type_object.h:
##########
@@ -87,7 +87,7 @@ class DataTypeObject : public IDataType {
}
std::stringstream error_string;
node.printTo(error_string);
- throw doris::Exception(ErrorCode::INTERNAL_ERROR, "Unkown literal {}",
error_string.str());
+ throw Exception(Status::FatalError("Unkown literal {}",
error_string.str()));
Review Comment:
why change this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
