zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1867503443
##########
be/src/service/backend_options.cpp:
##########
Review Comment:
dont change this file
##########
be/src/vec/exec/format/parquet/decoder.h:
##########
@@ -79,8 +79,8 @@ class Decoder {
}
virtual MutableColumnPtr convert_dict_column_to_string_column(const
ColumnInt32* dict_column) {
- LOG(FATAL) << "Method convert_dict_column_to_string_column is not
supported";
- __builtin_unreachable();
+ throw Exception(
Review Comment:
use NOT_IMP for this
##########
be/src/vec/olap/olap_data_convertor.h:
##########
@@ -455,8 +455,8 @@ class OlapBlockDataConvertor {
const void* get_data() const override { return _results.data(); };
const void* get_data_at(size_t offset) const override {
- LOG(FATAL) << "now not support get_data_at for
OlapColumnDataConvertorArray";
- __builtin_unreachable();
+ throw Exception(Status::FatalError(
Review Comment:
use NOT_IMP for them
##########
be/src/vec/data_types/data_type_nothing.cpp:
##########
Review Comment:
dont change this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
