zclllyybb commented on code in PR #42344:
URL: https://github.com/apache/doris/pull/42344#discussion_r1865210378
##########
be/src/vec/runtime/vdatetime_value.cpp:
##########
@@ -3433,8 +3433,7 @@ void DateV2Value<T>::unchecked_set_time(uint8_t hour,
uint8_t minute, uint8_t se
date_v2_value_.second_ = second;
date_v2_value_.microsecond_ = microsecond;
} else {
- LOG(FATAL) << "Invalid operation 'set_time' for date!";
- __builtin_unreachable();
+ throw Exception(Status::FatalError("Invalid operation 'set_time' for
date!"));
Review Comment:
you can just add `requires is_datetime` for this function declare and
definition and remove the `if-else`
##########
be/src/util/jni-util.cpp:
##########
@@ -241,7 +242,8 @@ void JniUtil::parse_max_heap_memory_size_from_jvm(JNIEnv*
env) {
}
}
if (0 == max_jvm_heap_memory_size_) {
- LOG(FATAL) << "the max_jvm_heap_memory_size_ is " <<
max_jvm_heap_memory_size_;
+ throw Exception(Status::FatalError("the max_jvm_heap_memory_size_ is
{}",
Review Comment:
dont change this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
