yiguolei commented on code in PR #50939:
URL: https://github.com/apache/doris/pull/50939#discussion_r2094292412
##########
fe/fe-core/src/main/java/org/apache/doris/service/arrowflight/DorisFlightSqlService.java:
##########
@@ -46,22 +46,19 @@ public class DorisFlightSqlService {
public DorisFlightSqlService(int port) {
BufferAllocator allocator = new RootAllocator();
- // arrow_flight_token_cache_size less than qe_max_connection to avoid
`Reach limit of connections`.
// arrow flight sql is a stateless protocol, connection is usually not
actively disconnected.
// bearer token is evict from the cache will unregister ConnectContext.
this.flightTokenManager = new FlightTokenManagerImpl(
- Math.min(Config.arrow_flight_token_cache_size,
Config.qe_max_connection / 2),
- Config.arrow_flight_token_alive_time);
+ Math.min(Config.arrow_flight_max_connections,
Config.arrow_flight_token_cache_size),
+ Config.arrow_flight_token_alive_time_minute);
this.flightSessionsManager = new
FlightSessionsWithTokenManager(flightTokenManager);
DorisFlightSqlProducer producer = new DorisFlightSqlProducer(
Location.forGrpcInsecure(FrontendOptions.getLocalHostAddress(), port),
flightSessionsManager);
flightServer = FlightServer.builder(allocator,
Location.forGrpcInsecure("0.0.0.0", port), producer)
.headerAuthenticator(new
FlightBearerTokenAuthenticator(flightTokenManager)).build();
- LOG.info("Arrow Flight SQL service is created, port: {},
token_cache_size: {}"
- + ", qe_max_connection: {}, token_alive_time: {}",
- port, Config.arrow_flight_token_cache_size,
Config.qe_max_connection,
- Config.arrow_flight_token_alive_time);
+ LOG.info("Arrow Flight SQL service is created, port: {},
max_connections: {}，token_alive_time: {}",
Review Comment:
打印日志的时候，对于时间类的，后面要加 min 或者 sec，否则看日志的时候，就得进去看代码才知道单位
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
