yiguolei commented on code in PR #50939:
URL: https://github.com/apache/doris/pull/50939#discussion_r2094292323
##########
fe/fe-core/src/main/java/org/apache/doris/service/arrowflight/DorisFlightSqlProducer.java:
##########
@@ -584,6 +592,25 @@ public void
getStreamCrossReference(CommandGetCrossReference command, CallContex
throw
CallStatus.UNIMPLEMENTED.withDescription("getStreamCrossReference
unimplemented").toRuntimeException();
}
+ @Override
+ public void closeSession(CloseSessionRequest request, final CallContext
context,
+ final StreamListener<CloseSessionResult> listener) {
+ // https://github.com/apache/arrow-adbc/issues/2821
+ // currently FlightSqlConnection does not provide a separate interface
for external calls to
+ // FlightSqlClient::closeSession(), nor will it automatically call
closeSession
+ // when FlightSqlConnection::close(). Python flight sql Cursor.close()
will call closeSession().
+ // Neither C++ nor Java seem to have similar behavior.
+ try {
+ flightSessionsManager.closeConnectContext(context.peerIdentity());
+ } catch (final Exception e) {
Review Comment:
and here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
