xinyiZzz commented on code in PR #50939:
URL: https://github.com/apache/doris/pull/50939#discussion_r2094381759
##########
fe/fe-common/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -2821,21 +2821,23 @@ public class Config extends ConfigBase {
})
public static int autobucket_max_buckets = 128;
- @ConfField(description = {"Arrow Flight
Server中所有用户token的缓存上限，超过后LRU淘汰，默认值为512, "
- + "并强制限制小于 qe_max_connection/2, 避免`Reach limit of connections`, "
- + "因为arrow flight sql是无状态的协议，连接通常不会主动断开，"
+ @ConfField(description = {"单个 FE 的 Arrow Flight Server 的最大连接数。",
+ "Maximal number of connections of Arrow Flight Server per FE."})
+ public static int arrow_flight_max_connections = 4096;
+
+ @ConfField(description = {"(已弃用，被 arrow_flight_max_connection 替代) Arrow
Flight Server中所有用户token的缓存上限，"
+ + "超过后LRU淘汰, arrow flight sql是无状态的协议，连接通常不会主动断开，"
+ "bearer token 从 cache 淘汰的同时会 unregister Connection.",
- "The cache limit of all user tokens in Arrow Flight Server. which
will be eliminated by"
- + "LRU rules after exceeding the limit, the default value is 512,
the mandatory limit is "
- + "less than qe_max_connection/2 to avoid `Reach limit of
connections`, "
- + "because arrow flight sql is a stateless protocol, the
connection is usually not actively "
- + "disconnected, bearer token is evict from the cache will
unregister ConnectContext."})
- public static int arrow_flight_token_cache_size = 512;
-
- @ConfField(description = {"Arrow Flight
Server中用户token的存活时间，自上次写入后过期时间，单位分钟，默认值为4320，即3天",
+ "(Deprecated, replaced by arrow_flight_max_connection) The cache
limit of all user tokens in "
+ + "Arrow Flight Server. which will be eliminated by LRU rules
after exceeding the limit, "
+ + "arrow flight sql is a stateless protocol, the connection is
usually not actively disconnected, "
+ + "bearer token is evict from the cache will unregister
ConnectContext."})
+ public static int arrow_flight_token_cache_size = 4096;
+
+ @ConfField(description = {"Arrow Flight
Server中用户token的存活时间，自上次写入后过期时间，单位分钟，默认值为1440，即1天",
"The alive time of the user token in Arrow Flight Server, expire
after write, unit minutes,"
- + "the default value is 4320, which is 3 days"})
- public static int arrow_flight_token_alive_time = 4320;
+ + "the default value is 1440, which is 1 days"})
+ public static int arrow_flight_token_alive_time_minute = 1440;
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
