github-actions[bot] commented on code in PR #65049:
URL: https://github.com/apache/doris/pull/65049#discussion_r3502913320
##########
fe/fe-core/src/main/java/org/apache/doris/system/BeSelectionPolicy.java:
##########
@@ -86,6 +87,12 @@ public Builder needQueryAvailable() {
public Builder needLoadAvailable() {
policy.needLoadAvailable = true;
+ policy.needNonDecommissioned = true;
+ return this;
Review Comment:
By making `needLoadAvailable()` imply `needNonDecommissioned()`, the
policy-backed load selectors now skip draining BEs, but the Kafka/Kinesis
routine-load metadata proxy selectors still bypass this policy.
`KafkaUtil.getInfoRequest()` and `KinesisUtil.getInfoRequest()` build
candidates with `backend.isLoadAvailable() && !backend.isDecommissioned()`
only; `isLoadAvailable()` does not check `isDecommissioning()`, and those
helpers then send `BackendServiceProxy.getInfo` to the selected BE. So an alive
decommissioning BE can still receive new routine-load Kafka/Kinesis metadata
RPCs even though the PR moves the other load-selection paths away from draining
BEs. Please add the same non-decommissioning predicate or a shared helper
there, with focused coverage for decommissioning metadata-proxy candidates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
