liaoxin01 commented on code in PR #65049:
URL: https://github.com/apache/doris/pull/65049#discussion_r3503136495


##########
fe/fe-core/src/main/java/org/apache/doris/cloud/load/CloudRoutineLoadManager.java:
##########
@@ -55,6 +55,7 @@ protected List<Long> getAvailableBackendIds(long jobId) 
throws LoadException {
                 .getBackendsByClusterName(routineLoadJob.getCloudCluster())
                 .stream()
                 .filter(Backend::isAlive)

Review Comment:
   Fixed in ac51c3d70a4: cloud routine-load backend selection now starts from 
Backend.isLoadAvailable() instead of only isAlive, while still excluding 
decommissioned/decommissioning BEs. Added a focused 
RoutineLoadBackendSelectionTest case for an alive load-disabled cloud backend.



##########
fe/fe-core/src/main/java/org/apache/doris/system/BeSelectionPolicy.java:
##########
@@ -86,6 +87,12 @@ public Builder needQueryAvailable() {
 
         public Builder needLoadAvailable() {
             policy.needLoadAvailable = true;
+            policy.needNonDecommissioned = true;
+            return this;

Review Comment:
   Fixed in ac51c3d70a4: KafkaUtil.getInfoRequest() and 
KinesisUtil.getInfoRequest() now also skip Backend.isDecommissioning() 
metadata-proxy candidates, matching the non-decommissioned load-selection 
behavior.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to