liaoxin01 commented on code in PR #65049:
URL: https://github.com/apache/doris/pull/65049#discussion_r3506272265
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/kafka/KafkaUtil.java:
##########
@@ -240,6 +240,7 @@ private static InternalService.PProxyResult
getInfoRequest(InternalService.PProx
Backend backend =
Env.getCurrentSystemInfo().getBackend(beId);
if (backend != null && backend.isLoadAvailable()
&& !backend.isDecommissioned()
+ && !backend.isDecommissioning()
&& !failedBeIds.contains(beId)
Review Comment:
Fixed in a6f91d2fe36: Kafka/Kinesis metadata candidate construction now uses
the same load-available/non-decommissioned predicate for both primary
candidates and blacklist fallback, and still removes stale null blacklist
entries.
##########
fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadManager.java:
##########
@@ -563,7 +565,7 @@ public long getAvailableBeForTask(long jobId, long
previousBeId) throws UserExce
}
// 4. on the basis of selecting the maximum idle slot be,
// try to reuse the object cache as much as possible
- if (previousBeIdleTaskNum == maxIdleSlotNum) {
+ if (previousBeAvailable && previousBeIdleTaskNum ==
maxIdleSlotNum) {
return previousBeId;
Review Comment:
Fixed in a6f91d2fe36: routine-load slot accounting now excludes
load-unavailable/decommissioned/decommissioning backends, and previous BE reuse
now requires a positive idle slot. Added a test covering a saturated previous
BE with idle capacity only on a decommissioning backend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
