Gabriel39 commented on code in PR #65784:
URL: https://github.com/apache/doris/pull/65784#discussion_r3610466530


##########
be/src/format_v2/column_mapper.cpp:
##########
@@ -2084,7 +2161,19 @@ const ColumnDefinition* 
TableColumnMapper::_find_file_field(
         });
         return field_it == file_schema.end() ? nullptr : &*field_it;
     }
-    return matcher_for_mode(_options.mode).find(table_column, file_schema);
+    const auto* matched = matcher_for_mode(_options.mode).find(table_column, 
file_schema);
+    if (matched != nullptr || _options.mode != 
TableColumnMappingMode::BY_FIELD_ID ||
+        !_options.allow_idless_complex_wrapper_projection || 
table_column.children.empty()) {
+        return matched;
+    }
+    const auto* wrapper = find_column_by_name(table_column, file_schema);

Review Comment:
   Fixed in b4909eb6c09. The V2 Parquet fallback now discovers a unique ID-less 
complex wrapper by shared descendant field IDs independently of authoritative 
name aliases; multiple candidates remain unmapped to avoid an ambiguous bind. 
Added mapper coverage and a real V2 Parquet reader result test for 
authoritative empty mappings.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to