Gabriel39 commented on code in PR #65784:
URL: https://github.com/apache/doris/pull/65784#discussion_r3610588736
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/source/IcebergScanNode.java:
##########
@@ -270,25 +273,27 @@ protected void doInitialize() throws UserException {
/**
* Extract name mapping from Iceberg table properties.
- * Returns a map from field ID to list of mapped names.
+ * Returns a present map, possibly empty, only when the property parsed
successfully.
*/
- private Map<Integer, List<String>> extractNameMapping() {
+ private Optional<Map<Integer, List<String>>> extractNameMapping() {
Map<Integer, List<String>> result = new HashMap<>();
+ String nameMappingJson =
icebergTable.properties().get(TableProperties.DEFAULT_NAME_MAPPING);
Review Comment:
Fixed in f1675c69232. The parsed name mapping (including absent vs
valid-empty) is now captured in IcebergSnapshotCacheValue from the same Iceberg
Table metadata generation as the statement schema, and IcebergScanNode reads
the pinned value from the MVCC snapshot. Added a property-refresh race
regression in IcebergScanNodeTest; the full class passes 17/17.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
