Gabriel39 commented on code in PR #65784:
URL: https://github.com/apache/doris/pull/65784#discussion_r3610589263
##########
be/src/format/table/table_schema_change_helper.cpp:
##########
@@ -660,37 +774,44 @@ Status
TableSchemaChangeHelper::BuildTableInfoUtil::by_parquet_field_id_with_nam
auto struct_node =
std::make_shared<TableSchemaChangeHelper::StructNode>();
std::map<int32_t, size_t> file_column_id_idx_map;
- bool all_have_field_id = true;
+ // Apply the same any-ID rule recursively so nested mixed-ID structs
retain ID matches.
+ bool has_field_id = false;
Review Comment:
Fixed in f1675c69232. V1 now computes the existential Parquet field-ID mode
once across the complete file schema and threads that decision through every
recursive struct/map/array match; the unique ID-less complex-wrapper exception
remains unchanged. Added both schema-helper and real IcebergParquetReader
regressions. The broader relevant BE run passes 26/26.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
