github-actions[bot] commented on code in PR #17585:
URL: https://github.com/apache/doris/pull/17585#discussion_r1129593883
##########
be/src/io/fs/s3_file_writer.h:
##########
@@ -33,13 +33,17 @@
namespace doris {
namespace io {
+class S3FileBuffer;
class S3FileWriter final : public FileWriter {
public:
- S3FileWriter(Path path, std::shared_ptr<Aws::S3::S3Client> client, const
S3Conf& s3_conf);
+ S3FileWriter(Path path, std::string key, std::string bucket,
std::shared_ptr<Aws::S3::S3Client>,
+ std::shared_ptr<S3FileSystem> fs, IOContext* state);
~S3FileWriter() override;
- Status close() override;
+ Status open() override;
+
+ Status close(bool sync = true) override;
Review Comment:
warning: non-virtual member function marked 'override' hides virtual member
function [clang-diagnostic-error]
```cpp
Status close(bool sync = true) override;
^
```
**be/src/io/fs/file_writer.h:38:** hidden overloaded virtual function
'doris::io::FileWriter::close' declared here: different number of parameters (0
vs 1)
```cpp
virtual Status close() = 0;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
