github-actions[bot] commented on code in PR #17585:
URL: https://github.com/apache/doris/pull/17585#discussion_r1129593866
##########
be/src/io/fs/s3_file_writer.h:
##########
@@ -33,13 +33,17 @@ class S3Client;
namespace doris {
namespace io {
+class S3FileBuffer;
class S3FileWriter final : public FileWriter {
Review Comment:
warning: abstract class is marked 'final'
[clang-diagnostic-abstract-final-class]
```cpp
class S3FileWriter final : public FileWriter {
^
```
**be/src/io/fs/file_writer.h:38:** unimplemented pure virtual method 'close'
in 'S3FileWriter'
```cpp
virtual Status close() = 0;
^
```
##########
be/src/io/fs/s3_file_writer.h:
##########
@@ -54,31 +58,78 @@
size_t bytes_appended() const override { return _bytes_appended; }
FileSystemSPtr fs() const override { return _fs; }
+ int64_t upload_cost_ms() const { return *_upload_cost_ms; }
-private:
- std::shared_ptr<S3FileSystem> _fs;
+ const Path& path() const override { return _path; }
Review Comment:
warning: only virtual member functions can be marked 'override'
[clang-diagnostic-error]
```suggestion
const Path& path() const { return _path; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
