github-actions[bot] commented on code in PR #17585:
URL: https://github.com/apache/doris/pull/17585#discussion_r1129593858
##########
be/src/io/fs/s3_file_writer.cpp:
##########
@@ -17,233 +17,241 @@
#include "io/fs/s3_file_writer.h"
-#include <aws/core/Aws.h>
#include <aws/core/utils/HashingUtils.h>
+#include <aws/core/utils/memory/stl/AWSStreamFwd.h>
+#include <aws/core/utils/memory/stl/AWSStringStream.h>
#include <aws/s3/S3Client.h>
#include <aws/s3/model/AbortMultipartUploadRequest.h>
#include <aws/s3/model/CompleteMultipartUploadRequest.h>
+#include <aws/s3/model/CompletedPart.h>
#include <aws/s3/model/CreateMultipartUploadRequest.h>
-#include <aws/s3/model/DeleteObjectRequest.h>
-#include <aws/s3/model/DeleteObjectsRequest.h>
-#include <aws/s3/model/GetObjectRequest.h>
#include <aws/s3/model/UploadPartRequest.h>
-#include <fmt/core.h>
-#include <sys/uio.h>
-#include <cerrno>
+#include <atomic>
+#include <memory>
+#include <utility>
-#include "common/compiler_util.h"
+#include "common/logging.h"
#include "common/status.h"
-#include "gutil/macros.h"
-#include "io/fs/file_writer.h"
-#include "io/fs/path.h"
#include "io/fs/s3_file_system.h"
-#include "util/doris_metrics.h"
-
-using Aws::S3::Model::AbortMultipartUploadRequest;
-using Aws::S3::Model::CompletedPart;
-using Aws::S3::Model::CompletedMultipartUpload;
-using Aws::S3::Model::CompleteMultipartUploadRequest;
-using Aws::S3::Model::CreateMultipartUploadRequest;
-using Aws::S3::Model::DeleteObjectRequest;
-using Aws::S3::Model::UploadPartRequest;
-using Aws::S3::Model::UploadPartOutcome;
+#include "io/fs/s3_file_write_bufferpool.h"
+#include "util/runtime_profile.h"
namespace doris {
namespace io {
-
-// max size of each part when uploading: 5MB
-static const int MAX_SIZE_EACH_PART = 5 * 1024 * 1024;
-static const char* STREAM_TAG = "S3FileWriter";
-
-S3FileWriter::S3FileWriter(Path path, std::shared_ptr<Aws::S3::S3Client>
client,
- const S3Conf& s3_conf)
- : FileWriter(std::move(path)), _client(client), _s3_conf(s3_conf) {
- DorisMetrics::instance()->s3_file_open_writing->increment(1);
- DorisMetrics::instance()->s3_file_writer_total->increment(1);
-}
+using namespace Aws::S3::Model;
+using Aws::S3::S3Client;
+
+S3FileWriter::S3FileWriter(Path path, std::string key, std::string bucket,
Review Comment:
warning: constructor for 'doris::io::S3FileWriter' must explicitly
initialize the base class 'doris::io::FileWriter' which does not have a default
constructor [clang-diagnostic-error]
```cpp
S3FileWriter::S3FileWriter(Path path, std::string key, std::string bucket,
^
```
**be/src/io/fs/file_writer.h:30:** 'doris::io::FileWriter' declared here
```cpp
class FileWriter {
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
