nishantmonu51 commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r205573709
########## File path: processing/src/main/java/io/druid/query/aggregation/NullableBufferAggregator.java ########## @@ -0,0 +1,116 @@ +/* + * Licensed to Metamarkets Group Inc. (Metamarkets) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. Metamarkets licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package io.druid.query.aggregation; + +import io.druid.common.config.NullHandling; +import io.druid.guice.annotations.PublicApi; +import io.druid.segment.BaseNullableColumnValueSelector; + +import javax.annotation.Nullable; +import java.nio.ByteBuffer; + +/** + * The result of a NullableBufferAggregator will be null if all the values to be aggregated are null values or no values + * are aggregated at all. If any of the value is non-null, the result would be the aggregated value of the delegate + * aggregator. Note that the delegate aggregator is not required to perform check for + * {@link BaseNullableColumnValueSelector#isNull()} on the selector as only non-null values will be passed to the + * delegate aggregator. This class is only used when SQL compatible null handling is enabled. + */ +@PublicApi +public final class NullableBufferAggregator implements BufferAggregator +{ + + private final BufferAggregator delegate; + private final BaseNullableColumnValueSelector selector; + + public NullableBufferAggregator(BufferAggregator delegate, BaseNullableColumnValueSelector selector) + { + this.delegate = delegate; + this.selector = selector; + } + + @Override + public void init(ByteBuffer buf, int position) + { + buf.put(position, NullHandling.IS_NULL_BYTE); + delegate.init(buf, position + Byte.BYTES); + } + + @Override + public void aggregate(ByteBuffer buf, int position) + { + boolean isNotNull = !selector.isNull(); + if (isNotNull) { + if (buf.get(position) == NullHandling.IS_NULL_BYTE) { + buf.put(position, NullHandling.IS_NOT_NULL_BYTE); + } + delegate.aggregate(buf, position + Byte.BYTES); + } + } + + @Override + @Nullable + public Object get(ByteBuffer buf, int position) + { + if (buf.get(position) == NullHandling.IS_NULL_BYTE) { + return null; + } + return delegate.get(buf, position + Byte.BYTES); + } + + @Override + public float getFloat(ByteBuffer buf, int position) + { + if (buf.get(position) == NullHandling.IS_NULL_BYTE) { + throw new IllegalStateException("Cannot return float for Null Value"); + } + return delegate.getFloat(buf, position + Byte.BYTES); + } + + @Override + public long getLong(ByteBuffer buf, int position) + { + if (buf.get(position) == NullHandling.IS_NULL_BYTE) { + throw new IllegalStateException("Cannot return long for Null Value"); + } + return delegate.getLong(buf, position + Byte.BYTES); + } + + @Override + public double getDouble(ByteBuffer buf, int position) + { + if (buf.get(position) == NullHandling.IS_NULL_BYTE) { + throw new IllegalStateException("Cannot return double for Null Value"); + } + return delegate.getDouble(buf, position + Byte.BYTES); + } + + @Override + public boolean isNull(ByteBuffer buf, int position) + { + return buf.get(position) == NullHandling.IS_NULL_BYTE || delegate.isNull(buf, position + Byte.BYTES); Review comment: this is to safeguard against any custom aggregators that result in null even when input is not null. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
