nishantmonu51 commented on a change in pull request #5958: Part 2 of changes 
for SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r205739736
 
 

 ##########
 File path: 
processing/src/main/java/io/druid/query/groupby/epinephelinae/RowBasedGrouperHelper.java
 ##########
 @@ -1700,6 +1712,78 @@ public BufferComparator getBufferComparator()
         return bufferComparator;
       }
     }
+
+    // This class is only used when SQL compatible null handling is enabled.
+    private class NullableRowBasedKeySerdeHelper implements 
RowBasedKeySerdeHelper
 
 Review comment:
   done.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to