nishantmonu51 commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r205575187
########## File path: processing/src/main/java/io/druid/query/aggregation/NullableAggregatorFactory.java ########## @@ -0,0 +1,114 @@ +/* + * Licensed to Metamarkets Group Inc. (Metamarkets) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. Metamarkets licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package io.druid.query.aggregation; + + +import io.druid.common.config.NullHandling; +import io.druid.guice.annotations.ExtensionPoint; +import io.druid.segment.BaseNullableColumnValueSelector; +import io.druid.segment.ColumnSelectorFactory; +import io.druid.segment.ColumnValueSelector; + +/** + * Abstract class with functionality to wrap {@link Aggregator}, {@link BufferAggregator} and {@link AggregateCombiner} + * to support nullable aggregations for SQL compatibility. Implementations of {@link AggregatorFactory} which need to + * Support Nullable Aggregations are encouraged to extend this class. + */ +@ExtensionPoint +public abstract class NullableAggregatorFactory<T extends BaseNullableColumnValueSelector> extends AggregatorFactory Review comment: sure, we can do that in a follow up PR, https://github.com/apache/incubator-druid/issues/6048 Apart from numeric ones, hyperunique and distinct count should also work although they do not extend nullableAggregatorFactory. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
