AmatyaAvadhanula commented on PR #17707: URL: https://github.com/apache/druid/pull/17707#issuecomment-2646327483
Thank you for these changes, @aho135! I think we would benefit from a change where we check if the spec has changed. If it hasn't we still restart the supervisor, but do not go to the metadata store and add an unnecessary entry in the spec history. Otherwise, the flow remains unchanged. I think @kfaraz has suggested this as well. I also wanted to understand if the problem was with the metadata operations associated with it including an unneeded entry, or if the supervisor operation is also problematic. If it is just the first case, is a feature flag really needed? I believe we should skip the metadata operation and history update as there is no benefit in both cases If you still believe that the supervisor operation is wasteful, and want to introduce a flag, please add the relevant docs in `docs/api-reference/supervisor-api.md`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
