aho135 commented on code in PR #17707:
URL: https://github.com/apache/druid/pull/17707#discussion_r1949704341
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/supervisor/SupervisorManager.java:
##########
@@ -166,6 +166,18 @@ public boolean
createOrUpdateAndStartSupervisor(SupervisorSpec spec)
}
}
+ public boolean wasSupervisorSpecModified(SupervisorSpec spec)
+ {
+ Preconditions.checkState(started, "SupervisorManager not started");
+ Preconditions.checkNotNull(spec, "spec");
+ Preconditions.checkNotNull(spec.getId(), "spec.getId()");
+ Preconditions.checkNotNull(spec.getDataSources(), "spec.getDatasources()");
+ synchronized (lock) {
+ Preconditions.checkState(started, "SupervisorManager not started");
+ return metadataSupervisorManager.wasSupervisorSpecModified(spec);
Review Comment:
Thanks for the review @kfaraz! I thought to do this in
MetadataSupervisorManager because the comparison relies on the ObjectMapper in
[SQLMetadataSupervisorManager](https://github.com/apache/druid/blob/master/server/src/main/java/org/apache/druid/metadata/SQLMetadataSupervisorManager.java#L62)
Let me dig more and see how to get the ObjectMapper into SupervisorManager
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
