aho135 commented on PR #17707: URL: https://github.com/apache/druid/pull/17707#issuecomment-2683686301
> Every language defaults boolean values to false and many treat null as false. > > Maybe a small thing but I feel like the feature flag should default to false when not present. Introducing the new flag as something like `skipRestartIfUnmodified=true` would be better. Thanks for the review @JRobTS Agreed that defaulting the flag to false makes more sense. I updated this in the subsequent PR. Please let me know what you think! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
