uds5501 opened a new pull request, #18341:
URL: https://github.com/apache/druid/pull/18341
### Description
The approach in general is this:
- I am using existing `FileTaskLogsConfig` class bound to
'druid.indexer.logs' that have druid.indexer.logs.storeTaskLogs option to
determine whether to push the logs to deep storage or not.
- Other runners can contact overlord at point of construction to verify
whether to push the logs or not. [in future PR]
- This same config option can be used by `/task/{taskId}/logs` endpoint to
return a message like “Log storage for completed tasks have been disabled,
please check your configuration”.
Other ideas:
- Reusing the `noop` TaskLog type to not push any logs at all.
- This would've worked fine if all task logs were being pushed from
overlord. Unfortunately, indexer / MM themselves have separate configs for
these so coordinating it altogether will be messy.
- We still need reports and `task.json` to be pushed, using a `noop`
type will break this.
<hr>
##### Key changed/added classes in this PR
* `KubernetesPeonLifecycle`
TODO: adding an embedded test to verify the same locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
