uds5501 commented on code in PR #18341:
URL: https://github.com/apache/druid/pull/18341#discussion_r2244545126
##########
indexing-service/src/main/java/org/apache/druid/guice/IndexingServiceTaskLogsModule.java:
##########
@@ -39,13 +42,22 @@ public class IndexingServiceTaskLogsModule implements Module
public void configure(Binder binder)
{
PolyBind.createChoice(binder, "druid.indexer.logs.type",
Key.get(TaskLogs.class), Key.get(FileTaskLogs.class));
+ PolyBind.createChoice(binder, "druid.indexer.logs.delegate.type",
Key.get(TaskLogs.class, Names.named("delegate")), Key.get(FileTaskLogs.class));
Review Comment:
> druid.indexer.logs.switching.logsType=hdfs
The options I am trying to provide here is different implementations of
`logStorage` vs `logStreaming`, maybe I could just extend this to
`druid.indexer.logs.switching.logs.storage` and
`druid.indexer.logs.switching.streaming` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]