kfaraz commented on code in PR #18302: URL: https://github.com/apache/druid/pull/18302#discussion_r2257582882
########## services/src/test/java/org/apache/druid/testing/embedded/EmbeddedDruidCluster.java: ########## @@ -232,13 +228,21 @@ public TestFolder getTestFolder() } /** - * The embedded Zookeeper server used by this cluster, if any. - * - * @throws NullPointerException if this cluster has no embedded zookeeper. + * Uses a container-friendly hostname for all embedded services, Druid as well + * as external. + */ + public EmbeddedDruidCluster useContainerFriendlyHostname() Review Comment: The current default (i.e. localhost) should already be good enough for all (non container) embedded tests. For Druid container based tests, users writing new tests need not be conscious of the choice as long as they extend `DockerTestBase`. Also, since Druid containers are not meant to be used frequently except in a couple of smoke tests, the extra step is probably okay? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
