capistrant commented on code in PR #18302: URL: https://github.com/apache/druid/pull/18302#discussion_r2258458691
########## services/src/test/java/org/apache/druid/testing/embedded/EmbeddedDruidCluster.java: ########## @@ -232,13 +228,21 @@ public TestFolder getTestFolder() } /** - * The embedded Zookeeper server used by this cluster, if any. - * - * @throws NullPointerException if this cluster has no embedded zookeeper. + * Uses a container-friendly hostname for all embedded services, Druid as well + * as external. + */ + public EmbeddedDruidCluster useContainerFriendlyHostname() Review Comment: ya, I agree. I'm probably just overthinking it since I'm currently working on the KafkaDataFormat tests which requires an extra docker container that can talk to the kafka container :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
