GWphua opened a new pull request, #18457:
URL: https://github.com/apache/druid/pull/18457

   ### Description
   
   
   #### Speed up `ChangeRequestHttpSyncer#onSuccess` by caching ObjectMapper's 
JavaType
   - Cache JavaType from provided TypeReference, so ObjectMapper no longer 
needs to call `constructType` everytime it tries to read from the stream.  
   - We can even consider making `ObjectMapper#readValue(InputStream, 
TypeReference<T>)` a forbidden API, given that we can use the more efficient 
`ObjectMapper#readValue(InputStream, JavaType)`.
   - No behavior change; request count and APIs remain the same.
   
   #### Release note
   <!-- Give your best effort to summarize your changes in a couple of 
sentences aimed toward Druid users. 
   
   If your change doesn't have end user impact, you can skip this section.
   
   For tips about how to write a good release note, see [Release 
notes](https://github.com/apache/druid/blob/master/CONTRIBUTING.md#release-notes).
   
   -->
   Internal deserialization optimization in `ChangeRequestHttpSyncer`
   
   <hr>
   
   ##### Key changed/added classes in this PR
    * `ChangeRequestHttpSyncer.java`
   
   <hr>
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not 
all of these items apply to every PR. Remove the items which are not done or 
not relevant to the PR. None of the items from the checklist below are strictly 
necessary, but it would be very helpful if you at least self-review the PR. -->
   
   This PR has:
   
   - [x] been self-reviewed.
   - [x] a release note entry in the PR description.
   - [x] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to