kfaraz commented on PR #18457: URL: https://github.com/apache/druid/pull/18457#issuecomment-3251689407
Thanks for sharing the benchmarks, @GWphua ! I am sorry but I fail to see a significant improvement, I must be missing something. In the second dataset, is the perf improvement when replacing `TypeReference` with `JavaType` from 12 ms to 11 ms per operation? We can merge off this PR if needed but I don't feel that it is really worth the effort right now to change all call sites that use `TypeReference`. To really attack the perf bottlenecks (either querying, ingestion or management), we can look at flamegraphs of services and specific threads to see where we are spending most of our time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
