GWphua commented on PR #18457: URL: https://github.com/apache/druid/pull/18457#issuecomment-3252894496
Yea, you are right about the lack of performance improvement @kfaraz From my flame graph below, I thought the performance to be because of the JsonMapper spending a lot of time to break down the type. Though, i found the bulk of the bottleneck is caused by Interval deserialization, which is addressed in #18477 <img width="1920" height="958" alt="image" src="https://github.com/user-attachments/assets/159ca5d5-6537-44b1-863f-6c680ff38198"; /> Still, its nice to see that we can get a performance enhancement via using JavaType / ObjectReader. We can merge this PR, especially since this path is called a lot especially for larger clusters. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
