jtuglu1 commented on code in PR #18480:
URL: https://github.com/apache/druid/pull/18480#discussion_r2325449655
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/LagBasedAutoScalerConfig.java:
##########
@@ -212,6 +218,15 @@ public AggregateFunction getLagAggregate()
return lagAggregate;
}
+ @Override
+ @JsonProperty
+ @Nullable
+ @JsonInclude(JsonInclude.Include.NON_NULL)
Review Comment:
Hmmm. Are we sure we want to do that? This would exclude ALL fields that are
`null`. In the case where there's some malformed input we may not include it in
the spec at all (not visible to the user). I'd prefer to reserve this for
fields which make sense to be nullable, and nullable fields tend to bloat the
config specs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
