jtuglu1 commented on code in PR #18480: URL: https://github.com/apache/druid/pull/18480#discussion_r2328458319
########## indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/LagBasedAutoScalerConfig.java: ########## @@ -49,6 +50,7 @@ public class LagBasedAutoScalerConfig implements AutoScalerConfig private final boolean enableTaskAutoScaler; private final long minTriggerScaleActionFrequencyMillis; private final AggregateFunction lagAggregate; + @Nullable private Double stopTaskCountPercent; Review Comment: > I just meant we should drop the @Nullable from @Nullable private Double stopTaskCountPercent I personally like to mark these things as `@Nullable` as it makes it clear when working the raw value that the value could be null (not just the accessor method). In that case `startTaskCount` annotation should also be changed. We should have a clear standard on these things (like [this](https://google.github.io/styleguide/javaguide.html#s4.8.5-annotations)) so style doesn't differ based on who is reviewing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org
