jtuglu1 commented on code in PR #18480: URL: https://github.com/apache/druid/pull/18480#discussion_r2328458319
########## indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/LagBasedAutoScalerConfig.java: ########## @@ -49,6 +50,7 @@ public class LagBasedAutoScalerConfig implements AutoScalerConfig private final boolean enableTaskAutoScaler; private final long minTriggerScaleActionFrequencyMillis; private final AggregateFunction lagAggregate; + @Nullable private Double stopTaskCountPercent; Review Comment: > I just meant we should drop the @Nullable from @Nullable private Double stopTaskCountPercent In that case `startTaskCount` annotation should also be changed. We should have a clear standard on these things so style doesn't differ based on who is reviewing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
