capistrant commented on code in PR #18844:
URL: https://github.com/apache/druid/pull/18844#discussion_r2699014643
##########
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java:
##########
@@ -462,6 +466,13 @@ public SegmentPublishResult commitSegmentsAndMetadata(
);
}
);
+
+ // Mark compaction state fingerprints as active after successful publish
+ if (result.isSuccess()) {
+ markIndexingStateFingerprintsAsActive(result.getSegments());
+ }
Review Comment:
My thinking was as follows:
1. I don't think we want marking as as active failing to impact the insert.
so even if we did add this to the first transaction, we'd still want to ignore
the result which feels weird to me.
2. The IndexingStateStorage interface would have one method that takes a txn
handle while the rest do whatever is necessary in their impl. And our
test/simulation storage implementation is memory only so accepting a txn handle
there is unusual.
I'm not closed off to the idea though if there are some upside I'm not
taking into account
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
